-
Notifications
You must be signed in to change notification settings - Fork 122
feat(akka): add an example using akka and compose #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey team, is there a chance we get a quick review on this? Much appreciated 🙏 @fiam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! Just some minor things.
- postgres-db | ||
ports: | ||
- "9000:9000" | ||
extra_hosts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does your application talk to host.docker.internal
explicitly? Otherwise, I think you can safelyr remove this extra_hosts
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, seems this can be removed 👍
STANDALONE_SINGLE_NODE: true | ||
DB_HOST: "postgres-db" | ||
HTTP_PORT: "9000" | ||
OPENAI_API_KEY: ${OPENAI_API_KEY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: could you please use a secret instead? There's an example for the compose.yaml
bits here, and this Dockerfile shows how to read the secret. The file that holds the secret should also be added to .gitignore
.
HTTP_PORT: "9000" | ||
OPENAI_API_KEY: ${OPENAI_API_KEY} | ||
|
||
networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is this required for the demo? I think this block might be dropped safely.
Basic example to use the Akka SDK AI Agent component: https://doc.akka.io/concepts/ai-agents.html